fix not clearing when given invalid values #1756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ticklemynausea thank you for your contribution. It seems there is a lot of churn in this area lately. Do you mind adding a test to show that the x should not show with an invalid value? Also per guidelines do not include the build files in your PR. We generate these during deployment. |
gwyneplaine
added a commit
that referenced
this pull request
Oct 25, 2017
gwyneplaine
added a commit
that referenced
this pull request
Oct 26, 2017
|
thanks for this @ticklemynausea, I've pulled out the crux of your PR into #2100 to be merged into master |
JedWatson
added a commit
that referenced
this pull request
Oct 26, 2017
fix not clearing when given invalid values, from #1756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when given an invalid value (not in the range of specified possible values), the select component shows the clear select icon despite being empty. this was determined to be caused by renderClear() being incorrectly called.
this PR simplifies the logic that determines when the clear icon is to be rendered.